fix(vendor): bootstrap.* assets should NOT be devextreme-dist content, partial revert (#33987)#34158
Merged
mpreyskurantov merged 3 commits intoJun 29, 2026
Conversation
…ackages/devextreme/, arrange vendor files (with bootstrap) (DevExpress#33987)" This reverts commit 7cec4ef. # Conflicts: # packages/devextreme/package.json # pnpm-lock.yaml
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the prior change that bundled bootstrap.* assets as part of devextreme-dist by removing bootstrap from the packages/devextreme vendor-copy pipeline, while adding bootstrap copying into the root build artifacts flow.
Changes:
- Removed bootstrap JS/CSS from
packages/devextremecopy:vendor:*targets so it’s no longer produced asdevextremepackage artifacts (and thus shouldn’t be included indevextreme-distcontent). - Updated the
all:buildscript (tools/scripts/build-all.ts) to copy bootstrap assets into the rootartifacts/jsandartifacts/cssdirectories.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/scripts/build-all.ts | Adds bootstrap asset copying into the root artifacts as part of all:build. |
| packages/devextreme/project.json | Removes bootstrap from the devextreme package vendor-copy inputs/outputs so it won’t be treated as devextreme-dist content. |
alexslavr
approved these changes
Jun 29, 2026
mpreyskurantov
changed the title
bootstrap.* assets should NOT be devextreme-dist content, revert (#33987)bootstrap.* assets should NOT be devextreme-dist content, partial revert (#33987)
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (partially) reverts:
The
bootstrap.*assets should not be thedevextreme-distcontent